Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

Commit

Permalink
build: fix node-chakracore arm build
Browse files Browse the repository at this point in the history
1. Exclude v8 gyp dependency if building node-chakracore
2. Explicitly specify CONSOLE subsystem for windows arm builds

PR-URL: #431
Reviewed-By: Oguz Bastemur <[email protected]>
Reviewed-By: Jimmy Thomson <[email protected]>
  • Loading branch information
digitalinfinity authored and kfarnung committed Jan 11, 2018
1 parent e9f02c4 commit 28c0fd3
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,14 @@
}],
],
}],
['target_arch=="arm"', {
'TargetMachine' : 3, # /MACHINE:ARM
'target_conditions': [
['_type=="executable"', {
'AdditionalOptions': [ '/SubSystem:Console,"6.02"' ],
}],
],
}],
],
'GenerateDebugInformation': 'true',
'GenerateMapFile': 'true', # /MAP
Expand Down

0 comments on commit 28c0fd3

Please sign in to comment.