Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

Commit

Permalink
[Merge chakra-core/ChakraCore@5d9535ac77] [MERGE #3190 @obastemur] xp…
Browse files Browse the repository at this point in the history
…lat: fix ICU lib tilde path problem

Merge pull request #3190 from obastemur:fix_tilde

Bash doesn't auto expand tilde on the path hence directory exists condition fails
  • Loading branch information
chakrabot authored and kfarnung committed Jul 14, 2017
1 parent 65e3ec1 commit 0fbfbf9
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion deps/chakrashim/core/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,8 @@ while [[ $# -gt 0 ]]; do

--icu=*)
ICU_PATH=$1
ICU_PATH="${ICU_PATH:6}"
# resolve tilde on path
eval ICU_PATH="${ICU_PATH:6}"
if [[ ! -d ${ICU_PATH} ]]; then
if [[ -d "${CHAKRACORE_DIR}/${ICU_PATH}" ]]; then
ICU_PATH="${CHAKRACORE_DIR}/${ICU_PATH}"
Expand Down

0 comments on commit 0fbfbf9

Please sign in to comment.