doc: update doc references from N-API to Node-API #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschlight
changed the title
gengjiawen
reviewed
Feb 18, 2021
README.md
Outdated
| @@ -7,19 +7,19 @@ Implementations of examples are named either after Node.js versions (`node_0.10` | |||
| `node_0.12`, etc), or Node.js addon implementation APIs: | |||
|
|
|||
| - [`nan`](https://github.com/nodejs/nan): C++-based abstraction between Node and direct V8 APIs. | |||
| - [`N-API`](https://nodejs.org/api/n-api.html): C-based API guaranteeing [ABI stability](https://nodejs.org/en/docs/guides/abi-stability/) across different node versions as well as JavaScript engines. | |||
| - [`node-addon-api`](https://github.com/nodejs/node-addon-api): header-only C++ wrapper classes which simplify the use of the C-based N-API. | |||
| - [`Node-API`](https://nodejs.org/api/n-api.html): C-based API guaranteeing [ABI stability](https://nodejs.org/en/docs/guides/abi-stability/) across different node versions as well as JavaScript engines. | |||
There was a problem hiding this comment.
Maybe add previously known as n-api ?
There was a problem hiding this comment.
I've added the reference to N-API.
gengjiawen
approved these changes
Feb 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR changes just the documentation including the Node-API Resource website.
See nodejs/abi-stable-node#420