-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update files from node #79
Conversation
Looks like we finally have a signature issue with node 4: https://travis-ci.org/kfarnung/node-addon-api/jobs/253006582
|
Opened a PR in node: nodejs/node#14211 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Added `node_internals.cc/h` to shim missing internal functions
* Added `util.h` and `util-inl.h` for incoming changes to error helpers
@mhdawson I added the missing macro/functions for your change. I rebased your PR against this code and everything built successfully. Pushed a branch here for CI run: https://github.com/kfarnung/node-addon-api/tree/n-api-errors |
* Added `node_internals.cc/h` to shim missing internal functions * Added `util.h` and `util-inl.h` for incoming changes to error helpers PR-URL: #79 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Jason Ginchereau <[email protected]>
Landed as 92d14c0 |
* Added `node_internals.cc/h` to shim missing internal functions * Added `util.h` and `util-inl.h` for incoming changes to error helpers PR-URL: nodejs/node-addon-api#79 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Jason Ginchereau <[email protected]>
* Added `node_internals.cc/h` to shim missing internal functions * Added `util.h` and `util-inl.h` for incoming changes to error helpers PR-URL: nodejs/node-addon-api#79 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Jason Ginchereau <[email protected]>
* Added `node_internals.cc/h` to shim missing internal functions * Added `util.h` and `util-inl.h` for incoming changes to error helpers PR-URL: nodejs/node-addon-api#79 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Jason Ginchereau <[email protected]>
* Added `node_internals.cc/h` to shim missing internal functions * Added `util.h` and `util-inl.h` for incoming changes to error helpers PR-URL: nodejs/node-addon-api#79 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Jason Ginchereau <[email protected]>
node_internals.cc/h
to shim missing internal functions