-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: explicitly disallow assign and copy #590
Conversation
Hi @legendecas, |
@NickNaso I found that this is what's done in Node.js core, v8, and NAN, lots of C++ projects. It can not be denied that with macros we could not get first sight of what's done after the macro expansion. Yet since disallowing assign/copy/move operations are so commonly used, and I cannot assume it would be easy to write such things every time without missing something. So a macro with a straightforward name describing what it would do will be helpful. And I'd assume it would not be confusing very much on this use case. |
@legendecas could you please rebase? |
@gabrielschulhof rebased :D |
PR-URL: #590 Reviewed-By: Gabriel Schulhof <[email protected]>
Landed in 79deefb. |
PR-URL: nodejs/node-addon-api#590 Reviewed-By: Gabriel Schulhof <[email protected]>
PR-URL: nodejs/node-addon-api#590 Reviewed-By: Gabriel Schulhof <[email protected]>
PR-URL: nodejs/node-addon-api#590 Reviewed-By: Gabriel Schulhof <[email protected]>
PR-URL: nodejs/node-addon-api#590 Reviewed-By: Gabriel Schulhof <[email protected]>
Use macros to explicitly disallow assign and copy.
npm test
passed.