Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement AsyncProgressQueueWorker #585
Implement AsyncProgressQueueWorker #585
Changes from 7 commits
630c005
01d157c
c558b42
95890af
0ced771
baa03a5
db62dfb
a8e76c4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this really do what we think it does? After all, we send the same pointer multiple times, so at the point of retrieval it will have the value it currently has on the thread. Also, if
i
goes out of scope, the main thread might crash. How aboutand then we delete on the main thread?
Nit: missing semcolon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Internally, the passed in data items are copied to internal slots and these allocations are managed by AsyncProgressQueueWorker.
Exposing passing raw pointers may have better control over the
Send
operation, but it also made the lifetime management of these data mandatory. Users have to manually delete the data pointers after the progress been handled.I'm leaning on the current behavior (copy the data) and this is what NAN provides. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we go with the
new uint32_t(i)
above.