Implement data manipulation methods for dataview #218
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mhdawson Could you please check this patch? |
sethbrenith
reviewed
Jan 25, 2018
napi-inl.h
Outdated
|
|
||
| template <typename T> | ||
| inline T DataView::ReadData(size_t byteOffset) const { | ||
| if (byteOffset + sizeof(T) > _length) { |
There was a problem hiding this comment.
Looks like this could overflow and let somebody read up to 7 bytes before _data. I'm not sure how an attacker could do anything useful with that, but it might be surprising.
There was a problem hiding this comment.
Good point. I've addressed your comment.
Thanks.
This change implements additional methods for manipulating data in the
dataview object. This change includes the following things:
- Get/Set${type} methods to manipulate data
- Tests for the methods
romandev
force-pushed
the
manipulation
branch
from
2bc2e68
to
3afe0fa
Compare
|
@romandev just back from being out for a week and still catching up. Will try and review later this week. |
|
@mhdawson Gentle ping. |
|
@romandev thanks for the reminder, have been pretty busy and at a conference this week but will try to find time to take a look. |
mhdawson
pushed a commit
that referenced
this pull request
Mar 1, 2018
This change implements additional methods for manipulating data in the
dataview object. This change includes the following things:
- Get/Set${type} methods to manipulate data
- Tests for the methods
PR-URL: #218
Reviewed-By: Michael Dawson <[email protected]>
|
Landed as 9c4d321 |
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
This change implements additional methods for manipulating data in the
dataview object. This change includes the following things:
- Get/Set${type} methods to manipulate data
- Tests for the methods
PR-URL: nodejs/node-addon-api#218
Reviewed-By: Michael Dawson <[email protected]>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
This change implements additional methods for manipulating data in the
dataview object. This change includes the following things:
- Get/Set${type} methods to manipulate data
- Tests for the methods
PR-URL: nodejs/node-addon-api#218
Reviewed-By: Michael Dawson <[email protected]>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
This change implements additional methods for manipulating data in the
dataview object. This change includes the following things:
- Get/Set${type} methods to manipulate data
- Tests for the methods
PR-URL: nodejs/node-addon-api#218
Reviewed-By: Michael Dawson <[email protected]>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
This change implements additional methods for manipulating data in the
dataview object. This change includes the following things:
- Get/Set${type} methods to manipulate data
- Tests for the methods
PR-URL: nodejs/node-addon-api#218
Reviewed-By: Michael Dawson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements additional methods for manipulating data in the
dataview object. This change includes the following things: