feat: allow catching all exceptions #1593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd like to discuss the naming of the new define We can use |
|
We discuss in the 18 Oct Node-API meeting:
|
NickNaso
reviewed
Oct 21, 2024
NickNaso
reviewed
Oct 21, 2024
KevinEady
force-pushed
the
catch-all-exceptions
branch
from
fc130ef
to
22357ab
Compare
KevinEady
force-pushed
the
catch-all-exceptions
branch
from
22357ab
to
b06737b
Compare
KevinEady
force-pushed
the
catch-all-exceptions
branch
from
b06737b
to
1e1e05e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1593 +/- ##
==========================================
- Coverage 66.35% 66.29% -0.07%
==========================================
Files 3 3
Lines 2143 2154 +11
Branches 703 708 +5
==========================================
+ Hits 1422 1428 +6
Misses 150 150
- Partials 571 576 +5 ☔ View full report in Codecov by Sentry. |
|
Hi @vmoroz @mhdawson @legendecas @gabrielschulhof , I believe this is ready. |
legendecas
reviewed
Nov 11, 2024
legendecas
reviewed
Nov 11, 2024
Co-authored-by: Chengzhong Wu <[email protected]>
KevinEady
force-pushed
the
catch-all-exceptions
branch
from
888abe9
to
df4e6b1
Compare
legendecas
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new compile-time define (
NODE_ADDON_API_CPP_EXCEPTIONS_ALL) to enable catching all exceptions. This must be used in conjunction withNODE_ADDON_API_CPP_EXCEPTIONS.Rename the
NAPI_prefixed exception preprocessor definitions (NAPI_CPP_EXCEPTIONSandNAPI_DISABLE_CPP_EXCEPTIONS) to be prefixed with our standardNODE_ADDON_API_prefix in a backwards-compatible way.Fixes: #1555