Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test] Unit test coverage for CallbackInfo #1048

Closed
JckXia opened this issue Aug 22, 2021 · 4 comments
Closed

[Test] Unit test coverage for CallbackInfo #1048

JckXia opened this issue Aug 22, 2021 · 4 comments
Labels
good first issue never-stale test

Comments

@JckXia
Copy link
Member

JckXia commented Aug 22, 2021 •
edited
Loading

class methods
CallbackInfo
Covered indirectly via call to Function::New CallbackInfo(napi_env env, napi_callback_info info)
Covered indreictly via call to create array buffers, etc Napi::Env Env() const
Covered Value NewTarget() const
Covered (see function.cc) bool IsConstructCall() const
Covered, function used by many tests size_t Length() const
Covered, function used by various tests const Value operator[] (size_t index) const
Covered, (see addon_data.cc) Value This() const
Covered, see function.cc void * Data() const
void SetData(void * Data)

Just wondering if it's worth writing seperate unit tests for this class?
@NickNaso NickNaso added the test label Aug 23, 2021
@github-actions
Copy link
Contributor

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

@github-actions github-actions bot added the stale label Dec 25, 2021
@NickNaso NickNaso removed the stale label Jan 10, 2022
@github-actions
Copy link
Contributor

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

@github-actions github-actions bot added the stale label Apr 15, 2022
@NickNaso NickNaso removed the stale label May 3, 2022
petersandor added a commit to petersandor/node-addon-api that referenced this issue May 10, 2022
@petersandor
test: CallbackInfo NewTarget() basic coverage (nodejs#1048)
6bd67e7
petersandor added a commit to petersandor/node-addon-api that referenced this issue May 10, 2022
@petersandor
test: CallbackInfo NewTarget() basic coverage (nodejs#1048)
d70cb25
petersandor added a commit to petersandor/node-addon-api that referenced this issue May 10, 2022
@petersandor
test: CallbackInfo NewTarget() basic coverage (nodejs#1048)
c5c8da3
JckXia pushed a commit that referenced this issue Jul 31, 2022
@petersandor @JckXia
test: CallbackInfo NewTarget() basic coverage (#1048)
134961d
@github-actions
Copy link
Contributor

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

@github-actions github-actions bot added the stale label Nov 11, 2022
@NickNaso NickNaso removed the stale label Nov 11, 2022
This was referenced Dec 20, 2022
Closed
Closed
@JckXia
Copy link
Member Author

JckXia commented Jan 3, 2023

Completed following #1253

@JckXia JckXia closed this as completed Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue never-stale test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NickNaso @JckXia