Add support for node::Encode/DecodeBytes/DecodeWrite. #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1816,6 +1816,45 @@ namespace Nan { | |||
| enum Encoding {ASCII, UTF8, BASE64, UCS2, BINARY, HEX, BUFFER}; | |||
| } | |||
|
|
|||
| NAN_INLINE v8::Local<v8::Value> NanEncode(const void *buf, size_t len, enum Nan::Encoding encoding = Nan::BINARY) { | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
The DecodeBytes() and DecodeWrite() calls that transpose BUFFER to BINARY work but perhaps it's clearer to call the corresponding Buffer methods directly. |
|
I did that first, but changed to this after I noticed the code paths would become identical as it felt cleaner and does not perform the same sanity checks twice. Otherwise I need to replicate a bunch of error checking (val is not, array, because 'raw' encoding is no longer supported) and other edge cases, which makes it grow more than one might first think. |
kkoopa
force-pushed
the
nodestuff
branch
2 times, most recently
from
6caf664 to
cfc4a08
Compare
|
Should be fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #250.