-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement progress to NanAsyncWorker. #207
Conversation
c73ddeb
to
c5bfbba
Compare
This should have everything we wanted from the discussion against the previous PR by @kkoopa. |
* | ||
* Copyright (c) 2014 NAN contributors | ||
* | ||
* MIT +no-false-attribs License <https://github.com/rvagg/nan/blob/master/LICENSE> |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
c5bfbba
to
8d6a160
Compare
Updated PR with fixes for @kkoopa's comments, as well as a fix to resolve a race condition I discovered. |
i'm testing this and it's working pretty well. i don't know much about C++ and stuff but i got it to work with @rvagg's help and it was pretty straight forward. so... a merge please!!! |
I am unfortunately extremely busy at the moment, I'll try to get it done next week. |
What we need and what we want are two possibly separate things. Fixes and such for broken code or new version incompatibilities are what is strictly needed. That includes #223 and a new thing: That should be it. Remaining improvements are probably better off for later versions. Oh yeah, we should test against io.js too. |
👍 |
This builds on NanAsyncWorker by providing a NanAsyncProgressWorker which can dispatch progress information back to the originator.