nan 2.0.0 breaks in [email protected]

[Raynos]

In file included from ../src/sse4_crc32.cpp:18:
../node_modules/nan/nan.h:1178:39: error: no member named 'REPLACE_INVALID_UTF8' in 'v8::String'
                          v8::String::REPLACE_INVALID_UTF8;
                          ~~~~~~~~~~~~^
1 error generated.
make: *** [Release/obj.target/sse4_crc32/src/sse4_crc32.o] Error 1

The sse4_crc32 module updated to nan@2 and broke my library in node 0.10.26

Does nan want to support node 0.10.26 ?

[kkoopa]

Nope, you have to use 0.10.29 or later.

[rvagg]

@kkoopa how difficult would this compatibility be? I know there are a few companies stuck on older versions and the security patches aren't relevant for their use cases.

[Raynos]

At least for uber we really should use 0.10.32. We have no reason to not upgrade.

The bigger blocker is the memory leak which makes 2.0.0 unusable ;)

[kkoopa]

Maintaining something this outdated is not worth the effort. It's currently 0.8.27+, 0.10.29+, 0.12.0+, 1.0.0+, 2.0.0+ and 3.0.0+, which is more than good enough. Everything takes precedence over supporting outdated minor versions of an outdated branch.

[bnoordhuis]

It's easy to check the NODE_{MAJOR,MINOR,PATCH}_VERSION macros but I'm ambivalent on whether it's a good idea.

[kkoopa]

Don't want to maintain more exceptions than necessary. This would also entail duplicating the functionality provided by https://gist.githubusercontent.com/tjfontaine/f869f373a8e9416809ba/raw/e3eb85201413a79d12ce24a7cb4b02edf0abc1a5/v0.10-invalid-utf8.patch

http://blog.nodejs.org/2014/06/16/openssl-and-breaking-utf-8-change/

The current version of Node 0.10 is 0.10.40, 0.10.29 was released over a year ago. I don't think requiring it at this point is aksing too much. If someone wants to run older versions of 0.10, they can apply the above patch themselves and build from source.

[bnoordhuis]

See #399.

[bnoordhuis]

Fixed by 60d6687.

@kkoopa Can we do a patch release for this? See e.g. fsevents/fsevents#78 for people that are waiting for it.

[kkoopa]

Sure, I've been meaning to do one, but it is blocked on #389. No point upgrading if everything leaks. Also need to merge #392 and then #397.

[bnoordhuis]

If it's already leaking in v2.0.0, then it's not a regression in v2.0.1, right? :-) The patch release makes things less worse for people stuck on older v0.10 versions.

[kkoopa]

Fine.