Skip to content
This repository has been archived by the owner on Sep 2, 2023. It is now read-only.

Unflagging announcement #434

Merged
merged 6 commits into from
Nov 20, 2019

Conversation

GeoffreyBooth
Copy link
Member

@GeoffreyBooth GeoffreyBooth commented Nov 17, 2019

This is a draft of a potential blog post to announce the unflagging of --experimental-modules. Almost all the text here comes from our 12.0.0 new implementation announcement or the Node ESM docs.

Rich text: https://github.com/nodejs/modules/pull/434/files?short_path=a0f536f#diff-a0f536f51fc94fbab6e56ead0a79c85f

@GeoffreyBooth GeoffreyBooth marked this pull request as ready for review November 17, 2019 07:42
@GeoffreyBooth
Copy link
Member Author

Also I think the deadline for this is quite soon, probably Monday 2019-11-18. Per nodejs/Release#487 the next release of Node.js will be on Tuesday 2019-11-19, which I’m presuming will be 13.2.0 and will contain the unflagging; so this announcement will likely need to go live then.

Copy link
Contributor

@DerekNonGeneric DerekNonGeneric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to #436: Unique behavior of package type searches that occur within a node_modules.

doc/unflagging-announcement.md Show resolved Hide resolved
doc/unflagging-announcement.md Outdated Show resolved Hide resolved
doc/unflagging-announcement.md Outdated Show resolved Hide resolved
doc/unflagging-announcement.md Outdated Show resolved Hide resolved
doc/unflagging-announcement.md Show resolved Hide resolved
doc/unflagging-announcement.md Outdated Show resolved Hide resolved
@GeoffreyBooth
Copy link
Member Author

I’m sorry @mathiasbynens, but this has already been sent to the communications team to post. Unless there are any outright errors in the text that we should rush to their attention to try to fix before they publish, I think we should keep the version in this repo matching whatever they post.

@MylesBorins
Copy link
Contributor

I'm going to go ahead and land this since text has been shared with marketing teM

@MylesBorins MylesBorins merged commit ccec868 into nodejs:master Nov 20, 2019
@GeoffreyBooth GeoffreyBooth deleted the unflagging-announcement branch November 20, 2019 23:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants