Skip to content
This repository has been archived by the owner on Nov 6, 2022. It is now read-only.

Increase default HTTP_MAX_HEADER_SIZE to 16kb #484

Closed
wants to merge 1 commit into from
Closed

Increase default HTTP_MAX_HEADER_SIZE to 16kb #484

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion http_parser.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ typedef unsigned __int64 uint64_t;
* to a very large number (e.g. -DHTTP_MAX_HEADER_SIZE=0x7fffffff)
*/
#ifndef HTTP_MAX_HEADER_SIZE
# define HTTP_MAX_HEADER_SIZE (80*1024)
# define HTTP_MAX_HEADER_SIZE (160*1024)
Copy link
Contributor

@ploxiln ploxiln Jun 20, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this changes the default of 80 KiB to 160 KiB

(nodejs was already setting a different max header size - either using http_parser_set_max_header_size(), or not using this http-parser at all, but rather https://github.com/nodejs/llparse - I'm not sure)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! I see that now. I'll investigate where this is supposed to go. I do wonder if this value should be set to the same as wherever else it is set in node?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repo is largely for the benefit of other users of this library besides nodejs, I think.

Take a look at:
https://github.com/nodejs/node/blob/v12.4.0/src/node_options.h#L186
https://github.com/nodejs/node/blob/v12.4.0/src/node_options.cc#L580
https://github.com/nodejs/node/blob/v12.4.0/deps/http_parser/http_parser.gyp#L59

note that it looks like this "legacy" parser is not the default, since 12.0 I think:
https://github.com/nodejs/node/blob/v12.4.0/src/node_options.cc#L319-L321

#endif

typedef struct http_parser http_parser;
Expand Down