This repository has been archived by the owner on Nov 6, 2022. It is now read-only.
Updated README.md #256
Closed
Updated README.md #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Included information and example on communicating data between thread local and callback scopes. This shows how http-parser can be used in a multi-threaded context.
| @@ -137,6 +137,47 @@ There are two types of callbacks: | |||
| Callbacks must return 0 on success. Returning a non-zero value indicates | |||
| error to the parser, making it exit immediately. | |||
|
|
|||
| For cases where it is necessary to pass local information to/from a callback the `http_parser` object's `data` field can be used. An example of such a case is when using threads to handle a socket connection, parse a request, and then give a response over that socket. By instantiation of a thread-local struct containing relevant data (e.g. accepted socket, allocated memory for callbacks to write into, etc), a parser's callbacks are able to communicate data between the scope of the thread and the scope of the callback in a threadsafe manner. This allows http-parser to be used in multi-threaded contexts. | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
LGTM, except one nit. cc @bnoordhuis because I'm pretty bad at english :( |
|
LGTM |
jasnell
pushed a commit
that referenced
this pull request
Oct 26, 2015
Included information and example on communicating data between thread local and callback scopes. This shows how http-parser can be used in a multi-threaded context. Reviewed-By: James M Snell <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> PR-URL: #256
|
Landed in 483eca7 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included information and example on communicating data between thread local and callback scopes. This shows how http-parser can be used in a multi-threaded context.