Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gyp: update shebang lines from python to python3 #94

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

DeeDeeG
Copy link
Contributor

@DeeDeeG DeeDeeG commented Feb 18, 2021

Fedora's .rpm package builder errors out upon encountering "ambiguous" python shebangs. Now that Python 2 support is dropped from gyp-next, it shouldn't hurt to switch these to python3.

See conversation at nodejs/node-gyp#2300 (comment) for more details of why I'm opening this Pull Request.

See also Fedora's policy about this: https://fedoraproject.org/wiki/Changes/Make_ambiguous_python_shebangs_error

Thanks.

This is mostly to make Fedora's .rpm builder happy.
But it won't hurt now that Python 2 is unsupported in gyp-next.
Copy link
Contributor

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants