-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: document how to apply a token with github-nodejs-bot #538
Conversation
31be506
to
3ef971a
Compare
3ef971a
to
30c52dd
Compare
30c52dd
to
2792f96
Compare
I don't think this document belongs here -- this repository is for the code running the bot server and not for the bot user. |
Well, this repo has the slogan of "@nodejs-github-bot's heart and soul" and the tokens are going to be used under the name of @nodejs-github-bot so I thought it would be easier to navigate here. And https://github.com/nodejs/admin/ is suitable for org-level requests, like creating a repo. |
I consider requesting a new token to be an org-level request. Maintaining the registry of tokens is certainly more the responsibility of the TSC rather than the github-bot team that maintains this repository. If the tokens are primarily for publishing to e.g. the npm registry, then arguably it's similar documentation to https://github.com/nodejs/admin/blob/main/npm-management.md. |
Make sense. Closing in favor of nodejs/admin#894. |
Document how to apply a fine-grained token with github-nodejs-bot's name.
After this landed, github-nodejs-bot tokens that are not fine-grained tokens like https://github.com/nodejs/docker-node/blob/main/.github/workflows/automatic-updates.yml#L28 may be updated to be fine-grained tokens.