Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ownership for Node.js tarball. Fixes #505 #573

Merged
merged 2 commits into from
Nov 8, 2017
Merged

Set ownership for Node.js tarball. Fixes #505 #573

merged 2 commits into from
Nov 8, 2017

Conversation

chorrell
Copy link
Contributor

@chorrell chorrell commented Nov 3, 2017

No description provided.

@chorrell
Copy link
Contributor Author

chorrell commented Nov 3, 2017

Hmm, the test builds timed out. I think it's taking a while trying to get the gpg keys after failing with the pgp.mit.edu server. I think we may want to change the order there so it tries ha.pool.sks-keyservers.net, then keyserver.pgp.com then pgp.mit.edu

SimenB

This comment was marked as off-topic.

@SimenB
Copy link
Member

SimenB commented Nov 3, 2017

CI timeout looks the same as #555

@chorrell
Copy link
Contributor Author

chorrell commented Nov 3, 2017

I'm trying to test locally, but I was getting odd failures and timeouts when trying to fetch the gpg keys.

@chorrell
Copy link
Contributor Author

chorrell commented Nov 3, 2017

Huh, I still get 500 as the user and group:

docker run -it --rm d05f1aa89751 ls -lan /usr/local/lib/node_modules/
total 12
drwxrwxr-x 3 500 500 4096 Oct 24 18:48 .
drwxrwxr-x 1 500 500 4096 Oct 24 18:48 ..
drwxrwxr-x 9 500 500 4096 Oct 24 18:48 npm

@chorrell
Copy link
Contributor Author

chorrell commented Nov 3, 2017

Yeah this doesn't work. I think the --owner=root --group=root options only apply to adding files, not for extracting. I did a local test with --no-same-owner and it does change the files to root

Looks like I need to change to using --no-same-owner

@chorrell
Copy link
Contributor Author

chorrell commented Nov 3, 2017

OK, I just pushed a commit that uses --no-same-owner instead.

pesho

This comment was marked as off-topic.

PeterDaveHello

This comment was marked as off-topic.

@SimenB
Copy link
Member

SimenB commented Nov 7, 2017

Should be merged so it's part of the 4, 6, 8 and 9 update today

(I'm not on a computer until tomorrow, so can't do it)

@PeterDaveHello
Copy link
Member

There seems to be conflicts, I'll wait for the other PR passed the tests first, and maybe help resolve the conflicts here if @chorrell is not here right now :)

@chorrell
Copy link
Contributor Author

chorrell commented Nov 7, 2017

I think this should be ok now.

@PeterDaveHello
Copy link
Member

Hmmm I'm not sure because v6.12 update is not merged yet. Unless we wants to merge this first.

@chorrell
Copy link
Contributor Author

chorrell commented Nov 8, 2017

That's fine, I can just rebase again.

@PeterDaveHello
Copy link
Member

@chorrell thanks, I think you can do it now :) Maybe we should remove the minor version number in the folder as @SimenB suggested, so we won't need to rebase so many times.

@chorrell
Copy link
Contributor Author

chorrell commented Nov 8, 2017

OK, I just pushed another rebase.

Yeah, I'd like to ditch the minor number too. We'll need to update generate-stackbrew-library.sh and probably some other scripts too.

@PeterDaveHello
Copy link
Member

@chorrell chorrell deleted the perms branch January 5, 2018 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants