-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set ownership for Node.js tarball. Fixes #505 #573
Conversation
Hmm, the test builds timed out. I think it's taking a while trying to get the gpg keys after failing with the pgp.mit.edu server. I think we may want to change the order there so it tries ha.pool.sks-keyservers.net, then keyserver.pgp.com then pgp.mit.edu |
CI timeout looks the same as #555 |
I'm trying to test locally, but I was getting odd failures and timeouts when trying to fetch the gpg keys. |
Huh, I still get 500 as the user and group:
|
Yeah this doesn't work. I think the Looks like I need to change to using |
OK, I just pushed a commit that uses |
Should be merged so it's part of the 4, 6, 8 and 9 update today (I'm not on a computer until tomorrow, so can't do it) |
There seems to be conflicts, I'll wait for the other PR passed the tests first, and maybe help resolve the conflicts here if @chorrell is not here right now :) |
I think this should be ok now. |
Hmmm I'm not sure because v6.12 update is not merged yet. Unless we wants to merge this first. |
That's fine, I can just rebase again. |
OK, I just pushed another rebase. Yeah, I'd like to ditch the minor number too. We'll need to update |
No description provided.