Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Alpine v3.5 #298

Closed
wants to merge 1 commit into from
Closed

Use Alpine v3.5 #298

wants to merge 1 commit into from

Conversation

PeterDaveHello
Copy link
Member

@PeterDaveHello PeterDaveHello commented Dec 28, 2016

Alpine v3.5 released!
docker-library/official-images#2489 merged 8 hours ago

@PeterDaveHello
Copy link
Member Author

cc @tianon

@tianon
Copy link
Contributor

tianon commented Dec 28, 2016

I'd recommend waiting on this change until after the Alpine image maintainers update latest to point to 3.5 (see docker-library/official-images#2489 (comment)).

@PeterDaveHello
Copy link
Member Author

Thanks @tianon

@Starefossen
Copy link
Member

Thanks @PeterDaveHello and @tianon 👍

Also, duplicate of #295

@PeterDaveHello
Copy link
Member Author

#295 build failed since it didn't wait for alpine v3.5 released on Docker hub but directly bump the version lol ...

@rreinurm
Copy link

I don't want to hold your horses, but I started to wonder. Should Nodejs build workgroup upgrade Jenkins-slave to Alpine 3.5 before merging this change? So that tests would be executed on same platform as docker image builds. Referring to current Jenkins build job https://ci.nodejs.org/job/node-test-commit-linux/nodes=ubuntu1604_docker_alpine34-64/

@chorrell
Copy link
Contributor

chorrell commented Jan 3, 2017

I think we should hold off on this for a while.

@shouze
Copy link

shouze commented Jan 3, 2017

@chorrell why?

@chorrell
Copy link
Contributor

chorrell commented Jan 3, 2017

For the reason as noted in #298 (comment)

I think it would be better to have testing of Alpine 3.5 setup first before we commit to this.

@PeterDaveHello
Copy link
Member Author

Now the alpine:latest is same as alpine:3.5 :)

@yosifkit
Copy link
Contributor

yosifkit commented Jan 5, 2017

Since there are many users that would install additional packages FROM node, then I would think it might be better to wait for a major bump to node. See also: docker-library/golang#131 (comment)

@chorrell
Copy link
Contributor

chorrell commented Jan 5, 2017

That seems pretty reasonable to me. Maybe switch to Alpine 3.5 for the upcoming (presumably ;) Node.js v8.0 image?

@Starefossen
Copy link
Member

Starefossen commented Jan 5, 2017 via email

@chorrell
Copy link
Contributor

Closing this in favour of switching to Alpine 3.5 for the v8 release only.

@kouhin
Copy link

kouhin commented Mar 15, 2017

@chorrell Alpine 3.4 has a serious dns bug when using this image with rancher.

gliderlabs/docker-alpine#8
rancher/rancher#5041

Hope it could be updated to 3.5 in the near future.

@shouze
Copy link

shouze commented Mar 15, 2017

@kouhin node 8 is forecasted for april so yes ;)

@chorrell
Copy link
Contributor

chorrell commented Mar 15, 2017

@kouhin Reading the gliderlabs/docker-alpine#8 thread, it looks like Alpine 3.5 does not fully resolve the dns bug, correct?

The current plan is to update to Alpine 3.5 for Node.js v8.x.x, but we'll also have to make the switch for the rest of the image versions when 3.4 drops out of support on 2018-05-01

@kouhin
Copy link

kouhin commented Mar 16, 2017

@chorrell Yes, you are right. Sorry for that.
3.5 does not resolve this problem and it seems that there are no workaround yet.

@westy92
Copy link
Contributor

westy92 commented Mar 17, 2017

Unfortunately I needed to use a package that was only available for 3.5+. Here's the steps I used to update the Alpine version to 3.5 using this image:

FROM node:6.10.0-alpine

# upgrade from Alpine v3.4 to v3.5
# see https://wiki.alpinelinux.org/wiki/Upgrading_Alpine#Upgrading_to_latest_release
RUN sed -i -e 's/v3\.4/v3.5/g' /etc/apk/repositories

# update Alpine Linux Package Manager
RUN apk add --no-cache --upgrade apk-tools

# update all packages
RUN apk upgrade --no-cache --available

# add needed packages
RUN apk add --no-cache \
  git
...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants