-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Alpine v3.5 #298
Use Alpine v3.5 #298
Conversation
cc @tianon |
I'd recommend waiting on this change until after the Alpine image maintainers update |
Thanks @tianon |
Thanks @PeterDaveHello and @tianon 👍 Also, duplicate of #295 |
#295 build failed since it didn't wait for alpine v3.5 released on Docker hub but directly bump the version lol ... |
I don't want to hold your horses, but I started to wonder. Should Nodejs build workgroup upgrade Jenkins-slave to Alpine 3.5 before merging this change? So that tests would be executed on same platform as docker image builds. Referring to current Jenkins build job https://ci.nodejs.org/job/node-test-commit-linux/nodes=ubuntu1604_docker_alpine34-64/ |
I think we should hold off on this for a while. |
@chorrell why? |
For the reason as noted in #298 (comment) I think it would be better to have testing of Alpine 3.5 setup first before we commit to this. |
Now the |
Since there are many users that would install additional packages |
That seems pretty reasonable to me. Maybe switch to Alpine 3.5 for the upcoming (presumably ;) Node.js v8.0 image? |
I am +1 for waiting until the release of Node.js 8.
… On 5 Jan 2017, at 19:39, Christopher Horrell ***@***.***> wrote:
That seems pretty reasonable to me. Maybe switch to Alpine 3.5 for the upcoming (presumably ;) Node.js v8.0 image?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Closing this in favour of switching to Alpine 3.5 for the v8 release only. |
@chorrell Alpine 3.4 has a serious dns bug when using this image with rancher. gliderlabs/docker-alpine#8 Hope it could be updated to 3.5 in the near future. |
@kouhin node 8 is forecasted for april so yes ;) |
@kouhin Reading the gliderlabs/docker-alpine#8 thread, it looks like Alpine 3.5 does not fully resolve the dns bug, correct? The current plan is to update to Alpine 3.5 for Node.js v8.x.x, but we'll also have to make the switch for the rest of the image versions when 3.4 drops out of support on 2018-05-01 |
@chorrell Yes, you are right. Sorry for that. |
Unfortunately I needed to use a package that was only available for 3.5+. Here's the steps I used to update the Alpine version to 3.5 using this image:
|
Alpine v3.5 released!
docker-library/official-images#2489 merged 8 hours ago