lookup: remove time #919
Merged
lookup: remove time #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `time` module has been skipped since Node.js 11, has not had a new version published in 5 years, and has a relatively low number of downloads.
richardlau
approved these changes
Jun 23, 2022
targos
approved these changes
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
timemodule has been skipped since Node.js 11, has not had a newversion published in 5 years, and has a relatively low number of
downloads.
Number of downloads per week is ~1,700. Also fails on all supported versions. The PR that skipped it in CITGM referenced TooTallNate/node-time#76, which I'd guess is unlikely to land.