Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lookup: temporarily use head for jest #899

Merged
merged 1 commit into from
Apr 9, 2022
Merged

Conversation

BethGriggs
Copy link
Member

Refs: #894 (comment)


Possibly not worth releasing on its own - but thinking it would be good to merge so we can run CITGM pointing to citgm#master to try and get green(er) results for Node.js 18.

@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2022

Codecov Report

Merging #899 (34372a9) into main (7d31334) will increase coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #899      +/-   ##
==========================================
+ Coverage   96.36%   96.45%   +0.09%     
==========================================
  Files          28       28              
  Lines        2145     2145              
==========================================
+ Hits         2067     2069       +2     
+ Misses         78       76       -2     
Impacted Files Coverage Δ
lib/match-conditions.js 94.00% <0.00%> (+2.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d31334...34372a9. Read the comment docs.

@BethGriggs BethGriggs mentioned this pull request Apr 8, 2022
21 tasks
@SimenB
Copy link
Member

SimenB commented Apr 9, 2022

👍

@targos targos merged commit 479d799 into nodejs:main Apr 9, 2022
@SimenB
Copy link
Member

SimenB commented Apr 10, 2022

Feel free to ping me when if it's still failing 👍

@SimenB
Copy link
Member

SimenB commented Apr 18, 2022

Did it help?

@SimenB
Copy link
Member

SimenB commented Apr 25, 2022

Jest 28 is out, can revert this PR 🙂

BethGriggs added a commit that referenced this pull request Apr 26, 2022
richardlau pushed a commit that referenced this pull request May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants