Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lookup: skip s390 and ppc for react #754

Merged
merged 1 commit into from
Oct 21, 2019
Merged

lookup: skip s390 and ppc for react #754

merged 1 commit into from
Oct 21, 2019

Conversation

andrewhughes101
Copy link
Contributor

React's failing on ppc and s390. The issue seems to be that it tries to download electron and there are no pre-compiled binaries of electron for these platforms.

Error: GET https://github.com/electron/electron/releases/download/v5.0.9/electron-v5.0.9-linux-ppc64.zip returned 404
 /home/iojs/tmp/citgm_tmp/490f84ce-553a-42cc-8633-20997dbe5f7d/react/node_modules/electron/install.js:49
   throw err
   ^
 Error: Failed to find Electron v5.0.9 for linux-ppc64 at https://github.com/electron/electron/releases/download/v5.0.9/electron-v5.0.9-linux-ppc64.zip

https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/

Checklist
  • npm test passes
  • contribution guidelines followed
    here

@codecov-io
Copy link

codecov-io commented Oct 21, 2019

Codecov Report

Merging #754 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #754   +/-   ##
=======================================
  Coverage   95.44%   95.44%           
=======================================
  Files          27       27           
  Lines         879      879           
=======================================
  Hits          839      839           
  Misses         40       40

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84187a6...b0427bd. Read the comment docs.

@targos targos merged commit 63e2dae into nodejs:master Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants