Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ref #683

Closed
wants to merge 1 commit into from
Closed

Remove ref #683

wants to merge 1 commit into from

Conversation

BridgeAR
Copy link
Member

@BridgeAR BridgeAR commented Mar 5, 2019

This removes ref for now as it will fail on all citgm runs currently
due to the testing framework not being compatible anymore. There are
two open PRs to fix this and as soon as either is merged, I'll open
a new PR to add ref back.

Refs: TooTallNate/ref#111

Checklist
  • npm test passes
  • tests are included
  • documentation is changed or added
  • contribution guidelines followed
    here

@codecov-io
Copy link

codecov-io commented Mar 5, 2019 •
edited
Loading

Codecov Report

Merging #683 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #683   +/-   ##
=======================================
  Coverage   94.41%   94.41%           
=======================================
  Files          26       26           
  Lines         823      823           
=======================================
  Hits          777      777           
  Misses         46       46

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e14df6...0e3c4e7. Read the comment docs.

@targos
Copy link
Member

targos commented Mar 5, 2019

Why not "skip": true?

@BridgeAR
Skip ref
0e3c4e7 
This skips ref for now as it will fail on all citgm runs currently
due to the testing framework not being compatible anymore. There are
two open PRs to fix this and as soon as either is merged, I'll open
a new PR to add `ref` back.
@BridgeAR
Copy link
Member Author

BridgeAR commented Mar 5, 2019

Updated

@BridgeAR
Copy link
Member Author

Seems like the actual breaking change was mocha (ref has * in the package.json and mocha released a new major). It seems an unintentional breaking change and now ref passes again on CITGM, so I'll close this.

@BridgeAR BridgeAR closed this Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BridgeAR @codecov-io @targos @richardlau