Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: support smartos (with hosts from Joyent) #64

Merged
merged 1 commit into from
Mar 14, 2015

Conversation

jbergstroem
Copy link
Member

This PR is standing on the shoulders of @geek's great job in #60. Please review.

@geek
Copy link
Member

geek commented Mar 10, 2015

LGTM

@geek geek mentioned this pull request Mar 10, 2015
@@ -94,6 +94,8 @@ The following companies are contributing hardware to this project:
* [DigitalOcean](http://digitalocean.com/) (via Mikeal Rogers)
* [Rackspace](http://rackspace.com/) (via Paul Querna)
* [IBM](http://www.ibm.com/) / [Softlayer](http://www.softlayer.com/) (via Dave Ings and Andrew Low)
* [Walmart](http://www.walmartlabs.com/) (via Wyatt Preul)
* [Joyent](http://joyent.com/)

This comment was marked as off-topic.

@rvagg
Copy link
Member

rvagg commented Mar 10, 2015

lgtm sans comments

@jbergstroem
Copy link
Member Author

Added TJ. I'll hold off for a second until we've sorted out DESTCPU since it might drop out of the manifest.

@jbergstroem
Copy link
Member Author

Ok, we're sticking with DESTCPU for now -- passing it to configure in jenkins. I'll squash and merge shortly -- thanks for reviewing.

jbergstroem added a commit to jbergstroem/build that referenced this pull request Mar 14, 2015
Add two new buildbots with hardware support from Joyent.
Most work from @geek. Closes nodejs#64.

PR-URL: nodejs#64
Reviewed-by: Wyatt Preul <[email protected]>
Reviewed-by: Rod Vagg <[email protected]>
Add two new buildbots with hardware support from Joyent.
Most work from @geek. Closes nodejs#64.

PR-URL: nodejs#64
Reviewed-By: Wyatt Preul <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants