Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Ansible playbook optimization #576

Conversation

piccoloaiutante
Copy link
Member

Starting from suggestions for a good first contribution that I received (#495) I've added few extra steps to Windows Ansible scripts:

  • Force Windows to do update
  • Reboot machine if necessary after update installation
  • Reboot machine after Visual Studio installation

As per #574 @joaocgreis can you test it on Windows 2008 Server R2 ? I already tested it on windows 10 and Windows Server 2012.

@jbergstroem
Copy link
Member

Interesting! Question: does the reboot stuff really work? I've been fighting with ansible about waiting at reboots (for the host to come back up).

@piccoloaiutante
Copy link
Member Author

piccoloaiutante commented Dec 20, 2016

@jbergstroem yes it worked on the two operating systems that I tested but I want to have a definitive response for @joaocgreis about Windows 2008 Server.

Here is the doc for the windows version. Have you tried to expand the reboot_timeout_sec?
https://docs.ansible.com/ansible/win_reboot_module.html

@jbergstroem
Copy link
Member

@piccoloaiutante no, i haven't tried windows rebooting at all -- its just a nightmare for !windows :\

joaocgreis pushed a commit that referenced this pull request Jan 7, 2017
Added update installation and reboot as first step and an extra reboot
after visual studio installation

PR-URL: #576
Reviewed-By: João Reis <[email protected]>
@joaocgreis
Copy link
Member

Landed in 5cd0f41

I took the liberty to clean up a bit and add a small header (<50char) to the commit message, hope it's ok. I tested in Windows 2008R2, the reboot works beautifully. Thanks @piccoloaiutante !

@joaocgreis joaocgreis closed this Jan 7, 2017
@piccoloaiutante
Copy link
Member Author

Excellent @joaocgreis now moving on generating .rdp and/or .remmina files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants