Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jenkins: use gcc 8 on the benchmark machines #2684

Merged
merged 1 commit into from
Jun 23, 2021

Conversation

richardlau
Copy link
Member

Selects gcc/g++ 8 on the benchmark machines when building Node.js 16
or later.

Fixes: #2681

Selects gcc/g++ 8 on the benchmark machines when building Node.js 16
or later.
Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're going to need to make sure we have ubuntu-toolchain-r onto 16.04 machines for this to work I think ... or get rid of them entirely

@richardlau
Copy link
Member Author

we're going to need to make sure we have ubuntu-toolchain-r onto 16.04 machines for this to work I think ... or get rid of them entirely

For reference, this happens in

#
# add PPA for gcc updates
#
- name: "repo : add Ubuntu Toolchain PPA"
apt_repository:
repo: 'ppa:ubuntu-toolchain-r/test'
state: present
update_cache: yes
register: has_updated_package_repo

@richardlau richardlau merged commit 2c89789 into nodejs:master Jun 23, 2021
@richardlau richardlau deleted the ubuntu1604 branch June 23, 2021 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update GCC on benchmark-ubuntu1604-intel-64
3 participants