Metrics #2518
Merged
Metrics #2518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
was just thinking about this again yesterday. hopeful to see it land soon. |
|
The latest commit ive just pushed up is an addition to the README of the metrics folder to give an explanation of the current flow of how the GCP flow currently works so its not just all in my head. LMT if its not clear at anypoint. |
|
Read it, generally makes sense to me. |
|
@nodejs/build can this get some reviews so I can land and start a fresh branch for the next steps please? |
richardlau
approved these changes
Jan 15, 2021
ansible/roles/metrics/files/process-cloudflare/process-cloudflare.js
Outdated
Show resolved
Hide resolved
mhdawson
reviewed
Jan 15, 2021
mhdawson
reviewed
Jan 15, 2021
ansible/roles/metrics/files/process-cloudflare/process-cloudflare.js
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #2025