Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update arm jump host proxycommand #1890

Merged
merged 1 commit into from
Aug 20, 2019
Merged

update arm jump host proxycommand #1890

merged 1 commit into from
Aug 20, 2019

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Aug 16, 2019

Updating the jump host command, -W isn't working anymore due to some restrictions I've placed on the jump host but nc will work just fine now. Further to #1889.

This is not replacing {{ ansible_ssh_private_key_file }} in the .ssh/config output of playbooks/write-ssh-config.yml and hasn't been for a while but I don't know why. Would appreciate some help tracking this down if someone has time.

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

Worked on the two release raspberry pis but not release-requireio-osx1010-x61-1

@sam-github
Copy link
Contributor

sam-github commented Aug 16, 2019

I'm checking this. Can someone confirm this is correct way to work-around the ansible bug:

s%{{ ansible_ssh_private_key_file }}%\~/ssh/nodejs_build_test%

@mhdawson
Copy link
Member

I believe so I just have:

ProxyCommand ssh -i ~/.ssh/nodejs_build_release -p 2222 [email protected] nc -q0 %h %p

@sam-github
Copy link
Contributor

sam-github commented Aug 16, 2019

@mhdawson Its a bit more complicated, the key that is substituted in has to be either ~/.ssh/nodejs_build_release or ~/.ssh/nodejs_build_test depending on the host... :-(. I guess that's why it would be good if ansible did this correctly, it should have that knowlege. I don't ATM have the time to do the context sensitive replacement (manually, with a script, or with ansible).

@joaocgreis
Copy link
Member

I investigated this a bit but wasn't able to take it all the way: #1483

Copy link
Member

@joaocgreis joaocgreis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly with Ansible 2.4.

@sam-github
Copy link
Contributor

OK, so it would be better to use ansible 2.4? We should mention that in the README -- I wonder if some of the warnings I see from ansible-playbook are because I'm using an ansible version that doesn't match the one the playbooks were developed for.

@rvagg
Copy link
Member Author

rvagg commented Aug 20, 2019

OK, so it would be better to use ansible 2.4

I avoid running it on my Mac these days where Python 3 is available and the Ansible that ships with brew has that baked in. I run from my Linux box which is still defaulting to Python 2. There's a bunch of other niggles in here that cause problems.

See #1399 for the stalled effort to address this. Someone needs to take this over.

@rvagg rvagg merged commit 4021ba5 into master Aug 20, 2019
@rvagg rvagg deleted the rvagg/ssh-proxy-command branch August 25, 2019 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants