Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run make test-v8-updates as a sub-job of node-test-commit-v8-linux #1342

Closed
mmarchini opened this issue Jun 14, 2018 · 3 comments
Closed

run make test-v8-updates as a sub-job of node-test-commit-v8-linux #1342

mmarchini opened this issue Jun 14, 2018 · 3 comments
Labels
ci-job-request ci-public

Comments

@mmarchini
Copy link
Contributor

As discussed in #1274 and nodejs/node#20783, we should add a sub-job to node-test-commit-v8-linux which runs make test-v8-updates on a Ubuntu 16.04 machine, otherwise tests for missing postmortem metadata and for Linux perf won't run during V8 updates.
@maclover7
Copy link
Contributor

@mmarchini Can you please prepare the full bash script for the job, and then I can drop that into a new job and setup the configuration for you

@mmarchini
Copy link
Contributor Author

Sure. The script should look like https://github.com/nodejs/build/pull/1329/files, right?

mmarchini pushed a commit to mmarchini/build that referenced this issue Jun 14, 2018
jenkins: add node-test-commit-v8-linux script
9a03fa2 
Ref: nodejs#1342
Ref: nodejs/node#20783
@mmarchini mmarchini mentioned this issue Jun 14, 2018
Closed
mmarchini pushed a commit to mmarchini/build that referenced this issue Jun 14, 2018
jenkins: add node-test-commit-v8-linux script
6916a66 
Ref: nodejs#1342
Ref: nodejs/node#20783
@mmarchini
Copy link
Contributor Author

v8-updates are running for node-test-commit-v8-linux, so this can be closed.

Ref: #1344 and #1344 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci-job-request ci-public
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maclover7 @mmarchini