Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travel fund: update travel fund for @ryzokuken (C+L Bengaluru 2018) #264

Merged
merged 1 commit into from
Nov 11, 2018

Conversation

ryzokuken
Copy link
Contributor

@ryzokuken ryzokuken commented Nov 5, 2018

Refs: nodejs/code-and-learn#88

Breakdown

Purpose Amount Requested
Airfare $200
Transportation $100

/cc @gireeshpunathil @thefourtheye

/cc @nodejs/community-committee @nodejs/tsc

Trott
Trott previously approved these changes Nov 5, 2018
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, I thought this was an adjustment to something else. I'm going to remove my approval, not because I disapprove but because I haven't actually reviewed this and defer to judgment of others. (Like, I don't know what "Miscellaneous" is for and if $100 is reasonable, but if others do know, then great!)

(If there's trouble getting sufficient reviews, I'll certainly hop back on here, ask whatever questions I have if any, and then approve if appropriate. I'm guessing that won't be necessary though....)

@Trott Trott dismissed their stale review November 5, 2018 21:39

whoops, I thought this was something else; happy to review and approve if necessary/appropriate, but defer to others who presumably know more details than me

@ryzokuken
Copy link
Contributor Author

Hi @Trott! I usually leave some amount as "miscellaneous" that I can draw from in case of unexpected costs or some of the other costs increasing beyond their usual limits (eg: super high transportation costs, sudden spike in airfare, etc.). I do this so that no matter what, I don't go over the upper limit that I initially request since I'm more comfortable requesting for more and ending up using less.

Personally, I think the final costs shouldn't really go above $200.

Would you be more comfortable if I requested for the lower cap instead?

@joyeecheung
Copy link
Member

@ryzokuken if it’s all transportation you can just put it as transportation - the foundation staff will validate the receipts and stuff eventually anyway, I believe

@ryzokuken
Copy link
Contributor Author

@joyeecheung Umm, that was way too obvious in hindsight, sorry. Made the change.

@gireeshpunathil
Copy link
Member

don't know whether my review is of any significance in this repo; still providing my LGTM as the co-ordinator of the Code & Learn event. thanks!

@ryzokuken
Copy link
Contributor Author

/cc @nodejs/tsc @nodejs/community-committee awaiting one approval from each committee.

@@ -46,3 +46,4 @@ Waleed | Ashraf | JS Interactive and Collaborator Summit | Attendance, Collabora
Saleh | Abdel Motaal | JS Interactive and Collaborator Summit | Attendance, Collaborate and Code & Learn | Vancouver BC, Canada | 10Oct -14Oct 2018 | US$1700 | 19Sep 2018 | https://github.com/nodejs/admin/pull/232 | | | | |
Anatoli | Papirovski | JS Interactive and Collaborator Summit | Attendance, Collaborate and Code & Learn | Vancouver BC, Canada | 9Oct - 13Oct 2018 | US$1633.53 | 26Sep 2018 | https://github.com/nodejs/admin/pull/235 | | | | |
Dan | Shaw | JS Interactive and Collaborator Summit | Attendance, Collaborate and Code & Learn | Vancouver, BC, CAN | 9oct - 14oct 2018 | US$1820 | | https://github.com/nodejs/admin/pull/224 | | | | |
Ujjwal | Sharma | Code & Learn, Bengaluru | Collaborate and Code & Learn | Bengaluru, India | 17th Nov 2018 | US$300 | 5th Sep 2018 | | | | | |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: The pull request date should be updated to 5th Nov 2018 I guess.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thefourtheye I thought this was optional. I could update this before landing?

@ryzokuken
Copy link
Contributor Author

@nodejs/community-committee could someone please look into this? The event is less than a week away and I'd need to start making arrangements.

Copy link
Contributor

@Tiriel Tiriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ryzokuken
Copy link
Contributor Author

Now that this has the required amount of approvals, could someone please merge this in so that I could finish preparations? Thanks.

@targos targos merged commit 23b4d9d into nodejs:master Nov 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants