Address some minor PR feedback #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasongin
force-pushed
the
feedback1
branch
2 times, most recently
from
f580df6
to
c69acfb
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
@mhdawson What question about whitespace changes? Did you see the note about whitespace in the PR description? |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
CI after rebase and merge: https://ci.nodejs.org/view/x%20-%20Abi%20stable%20module%20API/job/node-test-commit-linux-abi/81/ |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
- Simplify conversion to/from napi_value - Better names for CallbackWrapper template params - Fatal error when trying to set setter return value - Use node::arraysize - Replace v8::Handle with v8::Local - Align the star after v8::Isolate
|
CI after rebase and merge, again: https://ci.nodejs.org/view/x%20-%20Abi%20stable%20module%20API/job/node-test-commit-linux-abi/87/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing several comments in the PR:
Also:
causing some IDEs to auto-add a UTF-8 BOM