Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Burn down list of issues raised by module owners #281

Open
4 of 7 tasks
mhdawson opened this issue Oct 12, 2017 · 11 comments
Open
4 of 7 tasks

Burn down list of issues raised by module owners #281

mhdawson opened this issue Oct 12, 2017 · 11 comments
Assignees
Milestone

Comments

@mhdawson
Copy link
Member

mhdawson commented Oct 12, 2017

Community reported issues:

@mhdawson mhdawson added this to the Milestone 9 milestone Oct 12, 2017
@digitalinfinity digitalinfinity self-assigned this Oct 12, 2017
@digitalinfinity
Copy link
Contributor

I'll edit the issue to include the links to the issues that are being tracked by this meta-issue

@mhdawson
Copy link
Member Author

#279

@digitalinfinity
Copy link
Contributor

@mhdawson I've added a few issues here- feel free to update the issue to add any I might have missed (and I'll add more to this list as they come in)

@mhdawson
Copy link
Member Author

@digitalinfinity thanks !

@YafimK
Copy link

YafimK commented Oct 25, 2017

  • create custom env - when creating an async worker, you may want to manipulate env to be with another isolate. A bit closer to Node ENV.

@digitalinfinity
Copy link
Contributor

Thanks @YafimK - can you create a separate issue in nodejs/node with more details on what change you'd like to see, perhaps with the use case- I can then update the above list and link to that issue.

@digitalinfinity
Copy link
Contributor

For node-native-histogram, I've determined that the benchmark is not doing a significant amount of work, so its effectively just measuring the difference between napi_call_function and nan's function call API. Given that, I don't think we have to necessarily address this immediately since in most benchmarks where the benchmark does non-trivial work, the overhead difference would be less significant and so I'll check this off our list. However, I'll continue to look at whether there are more clever things we can do to reduce the absolute difference in overheads but napi_call_function will always have greater overhead since it's a more general API than nan.

@mhdawson mhdawson modified the milestones: Milestone 9, Milestone 10 Mar 15, 2018
@gabrielschulhof
Copy link
Collaborator

https://github.com/MayhemYDG/iltorb/tree/napi documents a slight memory leak wrt. V8 bindings.

@gabrielschulhof
Copy link
Collaborator

@mhdawson mhdawson modified the milestones: Milestone 10, Milestone 11 Sep 20, 2018
@NickNaso
Copy link
Member

Hi everyone I want report this issue kelektiv/node.bcrypt.js#709 developers are starting use ative addons in worker_threads so they need to refactor to implement a context aware addon.

@gabrielschulhof
Copy link
Collaborator

We discussed a possible solution to the accumulation of native finalizers during a tight loop that creates wrapped objects here:

nodejs/node-addon-api#1140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants