-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Burn down list of issues raised by module owners #281
Comments
I'll edit the issue to include the links to the issues that are being tracked by this meta-issue |
@mhdawson I've added a few issues here- feel free to update the issue to add any I might have missed (and I'll add more to this list as they come in) |
@digitalinfinity thanks ! |
|
Thanks @YafimK - can you create a separate issue in nodejs/node with more details on what change you'd like to see, perhaps with the use case- I can then update the above list and link to that issue. |
For node-native-histogram, I've determined that the benchmark is not doing a significant amount of work, so its effectively just measuring the difference between napi_call_function and nan's function call API. Given that, I don't think we have to necessarily address this immediately since in most benchmarks where the benchmark does non-trivial work, the overhead difference would be less significant and so I'll check this off our list. However, I'll continue to look at whether there are more clever things we can do to reduce the absolute difference in overheads but napi_call_function will always have greater overhead since it's a more general API than nan. |
https://github.com/MayhemYDG/iltorb/tree/napi documents a slight memory leak wrt. V8 bindings. |
Hi everyone I want report this issue kelektiv/node.bcrypt.js#709 developers are starting use ative addons in |
We discussed a possible solution to the accumulation of native finalizers during a tight loop that creates wrapped objects here: |
Community reported issues:
napi_create_async_work
(N-API feature request: expose API to resolve promises asynchronously without napi_create_async_work node#15604)The text was updated successfully, but these errors were encountered: