New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Buffer extend Uint8Array? #109

Closed

TimothyGu opened this issue Aug 17, 2017 · 0 comments

Member

TimothyGu commented Aug 17, 2017

It's this way in JS, so might be appropriate to make the C++ class extend Uint8Array as well.

mhdawson mentioned this issue

Burn down list of issues raised by module owners nodejs/abi-stable-node#281

Open

7 tasks

sampsongao mentioned this issue

Make Buffer extend Uint8Array instead of directly extending Object #188

Closed

mhdawson closed this as completed in

74de0cb

kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this issue


          Make Buffer extend Uint8Array

Make Buffer extend Uint8Array instead of directly extending Object

PR-URL: nodejs/node-addon-api#188
Fixes: nodejs/node-addon-api#109
Reviewed-By: Michael Dawson <[email protected]>

Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this issue


          Make Buffer extend Uint8Array

4340e70

Make Buffer extend Uint8Array instead of directly extending Object

PR-URL: nodejs/node-addon-api#188
Fixes: nodejs/node-addon-api#109
Reviewed-By: Michael Dawson <[email protected]>

wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this issue


          Make Buffer extend Uint8Array

389bac5

Make Buffer extend Uint8Array instead of directly extending Object

PR-URL: nodejs/node-addon-api#188
Fixes: nodejs/node-addon-api#109
Reviewed-By: Michael Dawson <[email protected]>

johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this issue


          Make Buffer extend Uint8Array

1eafb0c

Make Buffer extend Uint8Array instead of directly extending Object

PR-URL: nodejs/node-addon-api#188
Fixes: nodejs/node-addon-api#109
Reviewed-By: Michael Dawson <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment