Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add minutes for meeting 31 Jan 2018 #480

Closed
wants to merge 16 commits into from

Conversation

mhdawson
Copy link
Member

First copy/paste of minutes, may need some fixup.


### Announcements

*Extracted from **tsc-agenda** labelled issues and pull requests from the **nodejs org** prior to the meeting.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll update it in this PR, but can you update the template to use labeled (preferred US English spelling)?

@Trott
Copy link
Member

Trott commented Jan 31, 2018

@mhdawson Two things:

  • Can you update the template to use labeled (preferred US English spelling) instead of labelled in two places? (I've updated the PR here already.)

  • We are still seeing things like don.t instead of don't when you take minutes. Not sure what that's about, but FYI and if there's anything you can do about it, cool. (I'll fix them in this PR right now.)

@mhdawson
Copy link
Member Author

@Trott the ' -> . seenms to happen because of my cut and paste from chrome to a putty session. Not sure why it happens. I try to find/fix them but obviously don't catch them all.

I can only find one instance of 'labeled', which I've updated in the template.

* Ali Ijaz Sheikh @ofrobots (TSC)
* Daniel Bevenius @danbev (TSC)
* Colin Ihrig @cjihrig (TSC)
* ......... ...... ......... @ChALkeR (TSC)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I had fixed that, but seems not to have worked.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok if I use "view".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I think its ok.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed it after Timothy's comment.

mhdawson added a commit that referenced this pull request Feb 8, 2018
@mhdawson
Copy link
Member Author

mhdawson commented Feb 8, 2018

Landed as a886aa1

@mhdawson mhdawson closed this Feb 8, 2018

## Links

* **Recording**: https://www.youtube.com/watch?v=a6YtLIaqMqs

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mhdawson mhdawson deleted the minutesJan31 branch August 14, 2019 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants