Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nominating Sam Roberts (@sam-github) to the TSC #687

Closed
rvagg opened this issue Apr 4, 2019 · 18 comments
Closed

Nominating Sam Roberts (@sam-github) to the TSC #687

rvagg opened this issue Apr 4, 2019 · 18 comments

Comments

@rvagg
Copy link
Member

rvagg commented Apr 4, 2019

No objections from the TSC so far and Sam has given a 👍 so I'm nominating him for the TSC. The case for Sam on the TSC is that (a) he has a long history with Node core and that kind of perspective aids in continuity and stability and (b) he's essentially taking over leadership of crypto, or OpenSSL at least, an area where the TSC could do with more representation (I've been phasing out of that area and Sam has been picking up the reigns and I think he's a much better fit than me anyway!). I also expect that Sam is the most likely person to be handling many of the security releases in the near future and having an additional level of authority to get all of the awkward things done and being able to take responsibility for difficult decisions is helpful for that.

@sam-github
Copy link
Contributor

Thanks for the nomination, you all, I am looking forward to doing what I can to help the TSC.

@mhdawson
Copy link
Member

mhdawson commented Apr 4, 2019

I'll open a PR tomorrow to add @sam-github to the observer list for the next TSC meetings.

mhdawson added a commit to mhdawson/create-node-meeting-artifacts that referenced this issue Apr 5, 2019
mhdawson added a commit to nodejs/create-node-meeting-artifacts that referenced this issue Apr 8, 2019
* doc: add Sam Roberts as observer for TSC

PR-URL: #53
Refs: nodejs/TSC#687
Reviewed-By: Richard Lau <[email protected]>
@rvagg
Copy link
Member Author

rvagg commented Apr 29, 2019

I can't remember what the procedure with this is, is it 3 weeks observer then 4th week vote? @sam-github how many weeks has it been since you got to be an observer?

@Trott
Copy link
Member

Trott commented Apr 29, 2019

I can't remember what the procedure with this is, is it 3 weeks observer then 4th week vote? @sam-github how many weeks has it been since you got to be an observer?

It's been 3 the last few times. It used to be 4 but that seemed a bit longer than necessary to me.

@sam-github
Copy link
Contributor

@rvagg There have been 3 TSC meetings since I was added as an observer, I was present at the last 2 (the first was too early in my TZ).

@rvagg
Copy link
Member Author

rvagg commented Apr 30, 2019

Adding on agenda for whenever the next meeting happens, votes can be collected in here if you're not attending. A +1 from me obviously (next week's meeting is 2am for me and this week looks like it's being cancelled and is not a great time anyway).

@Trott
Copy link
Member

Trott commented Apr 30, 2019

+1

5 similar comments
@gireeshpunathil
Copy link
Member

+1

@danbev
Copy link
Contributor

danbev commented Apr 30, 2019

+1

@targos
Copy link
Member

targos commented Apr 30, 2019

+1

@cjihrig
Copy link
Contributor

cjihrig commented Apr 30, 2019

+1

@ChALkeR
Copy link
Member

ChALkeR commented Apr 30, 2019

+1

@jasnell
Copy link
Member

jasnell commented May 7, 2019

+1

2 similar comments
@mcollina
Copy link
Member

mcollina commented May 8, 2019

+1

@mhdawson
Copy link
Member

mhdawson commented May 8, 2019

+1

@rvagg
Copy link
Member Author

rvagg commented May 8, 2019

12 of 18 have either provided a +1 or a 👍, no negatives (that I'm aware of). This week's meeting might be cancelled, #700, so I'm going call this successful and welcome @sam-github on board.

I'll open a PR to the README in nodejs/node, when that's merged we can do the other permissiony things that need to be done.

Before that lands, there is still time if there are any remaining concerns among TSC members. Please voice them now or contact me, or someone else on the TSC that you trust that can make it actionable.

@rvagg
Copy link
Member Author

rvagg commented May 8, 2019

nodejs/node#27606

@gabrielschulhof
Copy link

+1

rvagg added a commit to rvagg/io.js that referenced this issue May 9, 2019
Voted on async in the TSC repo.
This adds him to the TSC list in the README.

Fixes: nodejs/TSC#687
rvagg added a commit to nodejs/email that referenced this issue May 9, 2019
rvagg added a commit to nodejs/create-node-meeting-artifacts that referenced this issue May 9, 2019
rvagg added a commit to nodejs/email that referenced this issue May 9, 2019
Ref: nodejs/node#27606
Ref: nodejs/TSC#687
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
mhdawson pushed a commit to nodejs/create-node-meeting-artifacts that referenced this issue May 9, 2019
targos pushed a commit to nodejs/node that referenced this issue May 9, 2019
Voted on async in the TSC repo.
This adds him to the TSC list in the README.

Fixes: nodejs/TSC#687

PR-URL: #27606
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Johnhvy pushed a commit to Johnhvy/NodeJS-Email that referenced this issue Jul 16, 2024
Ref: nodejs/node#27606
Ref: nodejs/TSC#687
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.