Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lazy_static, use ServiceMetrics struct instead #4

Merged

Conversation

expenses
Copy link

Hey, this'll probably be my last PR because I'm really happy with how things are working now! This PR replaces the lazy_staticed metrics with a ServicesMetrics struct so that we can avoid global variables.

@nodebreaker0-0
Copy link
Owner

It's a perfect solution.

@nodebreaker0-0 nodebreaker0-0 merged commit 5d3d9a7 into nodebreaker0-0:prometheus_v0.3 Jan 22, 2020
@mxinden
Copy link

mxinden commented Jan 22, 2020

@expenses thanks! This is great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants