Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for handler errors #42

Merged
merged 4 commits into from
Sep 20, 2019
Merged

Add tests for handler errors #42

merged 4 commits into from
Sep 20, 2019

Conversation

adenhertog
Copy link
Contributor

@adenhertog adenhertog commented Sep 20, 2019

As pointed out by @dropdevcoding in #41, any errors thrown by message handlers aren't caught and would be reported as an unhandled application exception with the message discarded.

This MR just adds a failing test to highlight the current bug, which should then start passing once #41 has been merged in.

@adenhertog
Copy link
Contributor Author

Looks like the bugfix from #41 worked, merging the tests to master.

@adenhertog adenhertog merged commit a497189 into master Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant