Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs/adfs/README.md and move to wiki #840

Merged
merged 4 commits into from
May 29, 2023
Merged

Update docs/adfs/README.md and move to wiki #840

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6a51070
Update README.md
1nbuc Jan 19, 2023
7147871
Added Powershell command to activate signing on message and aseertion…
1nbuc Jan 19, 2023
1a7f641
Remove from repo in favor of wiki
cjbarth May 29, 2023
6f9a2b0
Merge branch 'master' into pr/840
cjbarth May 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/adfs/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ passport.use(
privateKey: fs.readFileSync("/path/to/acme_tools_com.key", "utf-8"),
cert: fs.readFileSync("/path/to/adfs.acme_tools.com.crt", "utf-8"),
// other authn contexts are available e.g. windows single sign-on
// see: https://learn.microsoft.com/en-us/dotnet/api/system.identitymodel.tokens.authenticationmethods?view=netframework-4.8#fields
authnContext: [
"http://schemas.microsoft.com/ws/2008/06/identity/authenticationmethod/password",
],
Expand All @@ -57,6 +58,8 @@ passport.use(
racComparison: "exact", // default to exact RequestedAuthnContext Comparison Type
// From the metadata document
audience: "https://adfs.acme_tools.com/FederationMetadata/2007-06/FederationMetadata.xml",
// otherwise it will thow because of invalid document signature
wantAuthnResponseSigned: false,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want any example code to disable security features.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it is very confusing since this is the exact configuration for AD FS and not working out of the box.
If possible it could also be mentioned how to adjust the ADFS configuration to work with it but for me there was no other oppertunity than setting wantAuthnResponseSignedto false

},
function (profile, done) {
return done(null, {
Expand Down