Fix validateInResponseTo null check

[jamiees2]

Description

When validateInResponseTo isn't set to true, we end up setting it to false here:

passport-saml/src/node-saml/saml.ts

Line 155 in 13c7216

validateInResponseTo: ctorOptions.validateInResponseTo ?? false,

This value was then checked if it's not null here, which is always true. The intention was likely to have this check check if the value was true, like everywhere else this value is used. This changes the gate to just check if the value is true.

This is a small enough change so I won't default to writing a test for this edge behavior - an extra delete call to the cache provider isn't a big deal, but I found this when debugging our custom cache provider.

Checklist:

• Issue Addressed: [x]
• Link to SAML spec: [ ]
• Tests included? [ ]
• Documentation updated? [ ]

[cjbarth]

This looks good to me. Can you please create a matching PR against the node-saml project too so they stay in sync while we dis-entangle them?

[jamiees2]

Made node-saml/node-saml#4 :)