handle bad privateCert #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trap exceptions thrown by signRequest which can occurr when an invalid privateCert is passed to the saml object. Instead of throwing an exception pass the error along via the supplied callback added spec to check that the callback his hit with the error condtion when calling requestToUrl on the saml object
|
I ran into this issue today. Thanks for the patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trap exceptions thrown by signRequest which can occurr when an invalid
privateCert is passed to the saml object. Instead of throwing an
exception pass the error along via the supplied callback
added spec to check that the callback his hit with the error condtion when
calling requestToUrl on the saml object
Address issue: #230