Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set default ForceAuth: false #179

Closed
wants to merge 2 commits into from
Closed

Conversation

codeNgamer
Copy link

For IDP's who dont assume ForceAuthn: false, set explicit attribute to false

@pdspicer
Copy link
Contributor

SAML spec indicates this should default to false if not provided, BUT this would probably be a good option to include (as opposed to a fixed value). Would you mind amending your fix to include forceAuthn as an option that can be passed in via the constructor (and passed through to SAML)?

@cjbarth
Copy link
Collaborator

cjbarth commented Sep 25, 2018

@codeNgamer Do you have any interest in finishing this up?

@codeNgamer
Copy link
Author

Hey sorry, I've been swamped and haven't used this in a while but I think I can get this done this weekend. Sound good?

@cjbarth
Copy link
Collaborator

cjbarth commented Sep 26, 2018

Sounds good to me. Also, I think the value might already be allowed to pass through, so that might be worth checking before writing code. Thanks for giving time to this even tough you haven't used this in a while.

@cjbarth
Copy link
Collaborator

cjbarth commented Mar 19, 2021

@codeNgamer We will be releasing v3.x in the upcoming weeks. If you would like this included in that release, please address the latest comments and we'll get this landed.

@cjbarth
Copy link
Collaborator

cjbarth commented Jun 17, 2021

Closing due to inactivity. Please reopen if you wish to pursue this further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants