Fix Subject dereference bug #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `if (subject)` block is extended to cover all access to `subject`. We ran into this bug in the code because our SAML provider didn't include Subject at the root of the Assertion -> line 614 throws a 'cannot access 0 of undefined' error.
ploer
added a commit
that referenced
this pull request
Dec 30, 2015
|
Thanks for the PR; merged! (note that Travis tests were failing due to some scope issues; should be cleaned up now) |
cjbarth
added a commit
to cjbarth/passport-saml
that referenced
this pull request
Sep 10, 2018
…-string-signing * commit '094c660a0560625ccd29dbbffff4b7168844b4ef': Fix scope issues in PR node-saml#131. Refactor HTTP-Post tests to be a branch in existing authnRequest tests, rather than largely duplicated separate test. Remove a comment left behind in the wrong place (and content now covered in documentation) Minor documentation clarification. Changing HTTP-Post AuthnRequest binding option to be part of SAML object options, named authnRequestBinding, and adding to documentation. Add a basic test for HTTP-Post authn binding support (PR node-saml#129) Fix Subject dereference bug Update package.json Update package.json Added missing semicolon Adds HTTP-POST binding support for the SAML <AuthnRequest> Add test for new nameid attributes Do not sign custom query string parameters Only add to logout xml if present in authn response Add NameQualifier and SPNameQualifier to nameID
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
if (subject)block is extended to cover all access tosubject.We ran into this bug in the code because our SAML provider didn't include Subject at the root of the Assertion -> line 614 throws a 'cannot access 0 of undefined' error.