Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encrypted SLO Requests Fail #196

Closed
pdspicer opened this issue Mar 27, 2017 · 4 comments · Fixed by #408
Closed

Encrypted SLO Requests Fail #196

pdspicer opened this issue Mar 27, 2017 · 4 comments · Fixed by #408

Comments

@pdspicer
Copy link
Contributor

With the following (valid) SAML LogoutRequest, passport-saml fails to process the request as there it has no support in IDP-initiated SLO for decryption of Encrypted NameIDs:

<?xml version="1.0" encoding="UTF-8"?>
<saml2p:LogoutRequest Destination="https://localhost:8000/saml2/slo" ID="_14ce3210bed9ccf3227d9f380d8b3230" IssueInstant="2017-03-27T20:35:20.595Z" Version="2.0" xmlns:saml2p="urn:oasis:names:tc:SAML:2.0:protocol">
  <saml2:Issuer xmlns:saml2="urn:oasis:names:tc:SAML:2.0:assertion">https://localhost:4443/idp/shibboleth</saml2:Issuer>
  <ds:Signature xmlns:ds="http://www.w3.org/2000/09/xmldsig#">
    Omitted for brevity
  </ds:Signature>
  <saml2:EncryptedID xmlns:saml2="urn:oasis:names:tc:SAML:2.0:assertion">
    <xenc:EncryptedData Id="_45c5f58c6bd745b6174a5c04fd510f91" Type="http://www.w3.org/2001/04/xmlenc#Element" xmlns:xenc="http://www.w3.org/2001/04/xmlenc#">
      <xenc:EncryptionMethod Algorithm="http://www.w3.org/2001/04/xmlenc#aes256-cbc" xmlns:xenc="http://www.w3.org/2001/04/xmlenc#"/>
      <ds:KeyInfo xmlns:ds="http://www.w3.org/2000/09/xmldsig#">Omitted for brevity</ds:KeyInfo>
      <xenc:CipherData xmlns:xenc="http://www.w3.org/2001/04/xmlenc#">
        <xenc:CipherValue>Omitted for brevity</xenc:CipherValue>
      </xenc:CipherData>
    </xenc:EncryptedData>
  </saml2:EncryptedID>
  <saml2p:SessionIndex>_dde31adec05f7316ca073fcafffed219</saml2p:SessionIndex>
</saml2p:LogoutRequest>

This request is from Shibboleth IDP 3.2.1

@nkovalenko-sc
Copy link

The same problem with shibboleth.

@ryanmartinneutrino
Copy link

I have the same issue, also with Shibboleth. Would it be possible to have the PR reviewed and merged, I'm surprised that so few people have this issue.

@ricardosaracino
Copy link

Can someone point me in the direction of how to add aes256-cbc Assertion encryption support... i see this lib but not sure how to put it all together

https://github.com/auth0/node-xml-encryption

@hagis
Copy link

hagis commented Dec 10, 2019

We also need this fixed. Please review and merge the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants