-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using Node_pcap library to sniff the interface live and create pcap file #213
Open
harrydevnull
wants to merge
2
commits into
node-pcap:master
Choose a base branch
from
harrydevnull:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
under the hood it makes use of the libpcap's capability to create pcap the add-on makes use of the Async worker
harrydevnull
force-pushed
the
master
branch
from
September 30, 2016 20:16
ed491cb
to
f6585fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Node_pcap library to sniff the interface live and create pcap file.
currently there is no way in the existing library to create a pcap file. I have created a new method on the add on. A new parameter (total no of packets to be captured ) has been added. Even though code looks more or less the same; i felt it was better to keep to to different method and different js file for code maintainability. An example has been added as pcap_dump_test.js.
Please let me know this is pull request is good enough for getting merged.