Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node.js 18x #22

Closed
jurtle opened this issue Oct 18, 2023 · 2 comments · Fixed by #23
Closed

node.js 18x #22

jurtle opened this issue Oct 18, 2023 · 2 comments · Fixed by #23
Assignees
@fengmk2
Labels
enhancement

Comments

@jurtle
Copy link

jurtle commented Oct 18, 2023

This does not work with version 18 as import is now used.
@fengmk2 fengmk2 self-assigned this Oct 19, 2023
@fengmk2
Copy link
Member

fengmk2 commented Oct 19, 2023

Yep, I will release a major version to support commonjs end esm both in this week.

@fengmk2
Copy link
Member

fengmk2 commented Oct 19, 2023

eggjs/egg#5257

fengmk2 added a commit that referenced this issue Oct 28, 2023
@fengmk2
feat: support esm and cjs both
69971c4 
BREAKING CHANGE: Drop Node.js < 16 support

closes #22
@fengmk2 fengmk2 mentioned this issue Oct 28, 2023
Merged
fengmk2 added a commit that referenced this issue Oct 28, 2023
@fengmk2
feat: support esm and cjs both (#23)
8f9308f 
BREAKING CHANGE: Drop Node.js < 16 support

closes #22
fengmk2 pushed a commit that referenced this issue Oct 28, 2023
@semantic-release-bot
Release 2.0.0
e7a237f 
[skip ci]

## [2.0.0](v1.1.0...v2.0.0) (2023-10-28)

### ⚠ BREAKING CHANGES

* Drop Node.js < 16 support

closes #22

### Features

* support esm and cjs both ([#23](#23)) ([8f9308f](8f9308f))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fengmk2 fengmk2

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support esm and cjs both node-modules/urlencode
2 participants
@fengmk2 @jurtle