-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor in sync with node-fetch #43
Refactor in sync with node-fetch #43
Conversation
Codecov Report
@@ Coverage Diff @@
## master #43 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 62 39 -23
Branches 12 8 -4
=========================================
- Hits 62 39 -23
Continue to review full report at Codecov.
|
62d85e9
to
a320b45
Compare
I have another PR that will make this more obsolete on the way to resolve #40 |
did you know that
But i think node should never have added that, i do agree that subarray is better, if buffer extends Uint8Array and you can treat it as an regular Uint8Array to be isomorphic and uses either Buffer or Uint8Array on browser or node then it should behave the same way i think. |
I've basically tried to improve the file fitness of the class, removing the obsolete code, and making things easier. Do you prefer to wait with this PR until your changes merged and then roll it over, or should we merge this first? |
I have also bumped the node v to 10.17, used readable.from (also copied your jsDoc) will put up the PR now |
Sorry for handing you some conflicts |
a320b45
to
fd4f45e
Compare
This may be too much for one PR, but on other hand, this thing is small, so, it easier to review all in one.
This PR sync
fetch-blob
with latest changes innode-fetch@3
:Readable.from
prepublishOnly
- as resulted the reference to DOM library is removed (as discussed innode-fetch
). Runnpm run prepublishOnly
to see the output..slice
method by usingBuffer.subarray
No changes to tests were made.