Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI bug: semantic-release failed to release on PR merge #62

Closed
hsluoyz opened this issue Apr 28, 2022 · 9 comments
Closed

CI bug: semantic-release failed to release on PR merge #62

hsluoyz opened this issue Apr 28, 2022 · 9 comments
Assignees
Labels
bug Something isn't working

Comments

@hsluoyz
Copy link
Member

hsluoyz commented Apr 28, 2022

See: #61 (comment)

@casbin-bot
Copy link

@casbin-bot casbin-bot added the bug Something isn't working label Apr 28, 2022
@hsluoyz
Copy link
Member Author

hsluoyz commented Apr 28, 2022

@samstefan

@samstefan
Copy link
Contributor

It would seem that @semantic-release/commit-analyzer doesn't think that changes require a release, I'm not familiar with this tool but I'll try and look into why dependency changes aren't triggering a release.

Logs:

[12:40:58 AM] [semantic-release] [@semantic-release/commit-analyzer] › ℹ  The commit should not trigger a release
[12:40:58 AM] [semantic-release] [@semantic-release/commit-analyzer] › ℹ  Analysis of 2 commits complete: no release
[12:40:58 AM] [semantic-release] › ✔  Completed step "analyzeCommits" of plugin "@semantic-release/commit-analyzer"
[12:40:58 AM] [semantic-release] › ℹ  There are no relevant changes, so no new version is released.

@samstefan
Copy link
Contributor

@hsluoyz Is this because my commit messages didn't follow the semantic-release syntax, I used bug instead of fix?

@hsluoyz
Copy link
Member Author

hsluoyz commented Apr 29, 2022

@samstefan probably, I reverted these two failed commits, please make a new PR.

image

@hsluoyz hsluoyz closed this as completed Apr 29, 2022
@samstefan
Copy link
Contributor

@hsluoyz #63

@hsluoyz
Copy link
Member Author

hsluoyz commented Apr 29, 2022

@hsluoyz hsluoyz reopened this Apr 29, 2022
@samstefan
Copy link
Contributor

@hsluoyz I think that was the reverted release and was fixed with #63

It looks like the current release is passing and released fine: https://github.com/node-casbin/sequelize-adapter/runs/6228029418?check_suite_focus=true

@hsluoyz
Copy link
Member Author

hsluoyz commented Apr 29, 2022

@samstefan oh, never mind. It's great to see it works! Thx!

@hsluoyz hsluoyz closed this as completed Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants