Merge pull request #46 from Gabriel-403/fix#45

fix: removeFilteredNamedPolicy does not respect ptype
node-casbin · Jul 17, 2021 · 6eef10d · 6eef10d
2 parents 9dddfa9 + 35d1108
commit 6eef10d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/src/adapter.ts b/src/adapter.ts
@@ -234,6 +234,7 @@ export class SequelizeAdapter implements Adapter {
     ...fieldValues: string[]
   ): Promise<void> {
     const line = new CasbinRule();
+    line.ptype = ptype;
 
     const idx = fieldIndex + fieldValues.length;
     if (fieldIndex <= 0 && 0 < idx) {

diff --git a/test/adapter.test.ts b/test/adapter.test.ts
@@ -135,6 +135,14 @@ test(
         ['data2_admin', 'data2', 'write'],
       ]);
 
+      await a.removeFilteredPolicy('', 'p', 0, 'alice');
+      e = await newEnforcer('examples/rbac_model.conf', a);
+      testGetPolicy(e, [
+        ['bob', 'data2', 'write'],
+        ['data2_admin', 'data2', 'read'],
+        ['data2_admin', 'data2', 'write'],
+      ]);
+
       testGetGroupingPolicy(e, [['alice', 'data2_admin']]);
 
       // Remove groupingPolicy from DB