Add test that shards, exports and runs with IREE a Conv2DLayer #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sogartar
force-pushed
the
conv2d-numerical-inaccuracy
branch
from
0275524
to
30a5d52
Compare
stellaraccident
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Thanks for asking a test to guard the gate. Agreed we don't want much of these but some are good.
I think this will require some additional cleanup but let's land it first. Can you create an issue to simplify sharktank e2e tests and config options and tag this commit to it before landing? I'd like to get Scott to review a few of these that have surfaced in the repo together.
In general we should avoid having many end-to-end tests, but I decided to add it since it was the isolation of a real problem iree-org/iree#18283 and I already had the test. We would like to have at least several E2E tests of tiny models that run on every PR.
sogartar
force-pushed
the
conv2d-numerical-inaccuracy
branch
from
30a5d52
to
da3664b
Compare
|
I resolved the conflicts before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general we should avoid having many end-to-end tests, but I decided to add it since it was the isolation of a real problem
iree-org/iree#18283
and I already had the test.
We would like to have at least several E2E tests of tiny models that run on every PR.