Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tuner] Add abstractmethod in autotune.py. Create punet_autotune.py #98

Merged
merged 20 commits into from
Aug 19, 2024

Conversation

RattataKing
Copy link
Contributor

@RattataKing RattataKing commented Aug 16, 2024

  • Rename variables/functions with "unet" in their names in autotune.py and test_autotune.py
  • Add class TuningClient and DefaultTuningClient in autotune.py
  • Add punet_autotune.py
  • Edit dir and path names in existing bash scripts

This PR generalized tuner by providing a basic python class API, decoupled it from the specific model (i.e. punet). The final goal is to make tuner support models other than SDXL.

@RattataKing RattataKing requested a review from kuhar August 16, 2024 18:38
tuning/autotune.py Outdated Show resolved Hide resolved
tuning/autotune.py Outdated Show resolved Hide resolved
tuning/autotune.py Outdated Show resolved Hide resolved
tuning/autotune.py Outdated Show resolved Hide resolved
tuning/punet_autotune.py Outdated Show resolved Hide resolved
Copy link
Member

@kuhar kuhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kuhar kuhar merged commit 3ab8c65 into main Aug 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants